Notify instead of error when no elements on rank#1552
Merged
Conversation
Contributor
Author
|
/style |
Member
This functionality was disabled for reasons... you have engaged Chris Style Bot! Commit coming soon! |
Contributor
Author
|
I broke my build doing codevelop things and couldn't easily run styling myself. Thank you for jumping on it! |
Contributor
Author
Shame... was going to try |
btalamini
approved these changes
Mar 10, 2026
Member
btalamini
left a comment
btalamini
left a comment
There was a problem hiding this comment.
Thanks. I think it's a good idea if users are notified that there are empty ranks.
white238
reviewed
Mar 10, 2026
white238
approved these changes
Mar 10, 2026
white238
deleted the
watts24/Notify-instead-of-error-when-no-elements-on-rank
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1476, we added a
SLIC_ERRORif the partitioning of themfem::ParMesh/smith::Meshleft zero elements on any rank. However, per recent discussions with the MFEM team, themfem::ParMeshand everything built on top of it (ParFiniteElementSpaces,ParGridFunctions, ...) should Just Work even when the partitioning results in no elements/dofs being owned by one or more ranks. We have confirmed that this is the case, and also that (at least in common usage), so does Smith.In some cases, the user may not intend for such a partitioning, and may therefore want to kill the job and adjust the run size or mesh creation. However, in other use cases, particularly when there are meshes of different dimension/refinement on the same MPI communicator, this may be expected and intended. This PR therefore replaces the
SLIC_ERRORwith aSLIC_INFOmessage so that the user is notified about the partitioning, but otherwise code execution keeps moving.Update: #1549 Removed the
SLIC_ERRORcalls entirely. That resolves the intent of this PR. If theSLIC_INFOis more than necessary, I'm happy to close without merging.